Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lexing of multiline comments to include the trailing '/' #2359

Merged
merged 3 commits into from
Jul 22, 2022
Merged

Fix lexing of multiline comments to include the trailing '/' #2359

merged 3 commits into from
Jul 22, 2022

Conversation

mitchmindtree
Copy link
Contributor

Previously, both the implementation and the test missed the trailing
slash during lexing. This fixes both, closes #2355 and unblocks #2311.

@mitchmindtree
Fix lexing of multiline comments to include the trailing '/'
c27f9d4 
Previously, both the implementation and the test missed the trailing
slash during lexing. This fixes both, closes #2355 and unblocks #2311.
@mitchmindtree mitchmindtree added bug Something isn't working P: critical Should be looked at before anything else compiler: parser Everything to do with the parser labels Jul 22, 2022
@mitchmindtree mitchmindtree requested review from kayagokalp and a team July 22, 2022 00:58
@mitchmindtree mitchmindtree self-assigned this Jul 22, 2022
JoshuaBatty
JoshuaBatty previously approved these changes Jul 22, 2022
View reviewed changes
@mitchmindtree
Copy link
Contributor Author

Hrmmrmmm seemingly unrelated cargo-unused-deps-check error.

Seems like potentially some issue in nightly-Rust causing a new compile error to appear in mdbook 0.4.19 🤔

This was referenced Jul 22, 2022
Merged
Closed
Closed
@JoshuaBatty JoshuaBatty self-requested a review July 22, 2022 06:01
@mitchmindtree mitchmindtree enabled auto-merge (squash) July 22, 2022 06:01
@mitchmindtree mitchmindtree requested a review from a team July 22, 2022 06:10
@JoshuaBatty JoshuaBatty requested a review from a team July 22, 2022 06:11
@mitchmindtree mitchmindtree merged commit 91a60a6 into master Jul 22, 2022
@mitchmindtree mitchmindtree deleted the mitchmindtree/fix-multiline-comment-lex branch July 22, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@otrho otrho otrho approved these changes

@kayagokalp kayagokalp Awaiting requested review from kayagokalp

Assignees

@mitchmindtree mitchmindtree

Labels
bug Something isn't working compiler: parser Everything to do with the parser P: critical Should be looked at before anything else
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comment lexing misses trailing / for multi-line comments
3 participants
@mitchmindtree @otrho @JoshuaBatty